Skip to content

Conversation

@ch1ago
Copy link
Member

@ch1ago ch1ago commented May 21, 2016

image

/Users/tj/github/opensource/oauth-ruby/lib/oauth/client/net_http.rb:2: warning: loading in progress, circular require considered harmful - /Users/tj/github/opensource/oauth-ruby/lib/oauth/client/helper.rb
  from /Users/tj/.rvm/gems/ruby-2.3.0/gems/rake-11.1.2/lib/rake/rake_test_loader.rb:4:in  `<main>'
  from /Users/tj/.rvm/gems/ruby-2.3.0/gems/rake-11.1.2/lib/rake/rake_test_loader.rb:4:in  `select'
  from /Users/tj/.rvm/gems/ruby-2.3.0/gems/rake-11.1.2/lib/rake/rake_test_loader.rb:15:in  `block in <main>'
  from /Users/tj/.rvm/gems/ruby-2.3.0/gems/rake-11.1.2/lib/rake/rake_test_loader.rb:15:in  `require'
  from /Users/tj/github/opensource/oauth-ruby/test/integration/consumer_test.rb:1:in  `<top (required)>'
  from /Users/tj/github/opensource/oauth-ruby/test/integration/consumer_test.rb:1:in  `require'
  from /Users/tj/github/opensource/oauth-ruby/test/test_helper.rb:14:in  `<top (required)>'
  from /Users/tj/github/opensource/oauth-ruby/test/test_helper.rb:14:in  `require'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth.rb:9:in  `<top (required)>'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth.rb:9:in  `require'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth/client/helper.rb:2:in  `<top (required)>'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth/client/helper.rb:2:in  `require'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth/consumer.rb:4:in  `<top (required)>'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth/consumer.rb:4:in  `require'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth/client/net_http.rb:2:in  `<top (required)>'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth/client/net_http.rb:2:in  `require'

@ch1ago ch1ago merged commit 601f251 into master May 27, 2016
@ch1ago ch1ago deleted the silence_circular_dependency_warning branch May 27, 2016 18:06
@matthutchinson
Copy link

Can you issue a new gem release with this fix? (and other warning messages etc.) to silence the warning noise on Rubies >= 2.3.1

@ch1ago
Copy link
Member Author

ch1ago commented May 17, 2017

Sure, give me some 30 minutes and I'll release it

@ch1ago
Copy link
Member Author

ch1ago commented May 17, 2017

@matthutchinson done

@matthutchinson
Copy link

Wow, that was fast! Thanks ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants