Skip to content

Conversation

@xprazak2
Copy link

From my debugging session:

request is ActionDispatch::Request, which is not in available_proxies and it no longer inherits from Rack::Request as correctly stated in previous discussion, it only mixes in Rack::Request::Env and Rack::Request::Helpers:

so there is no superclass match and klass.nil? #=> true

@xprazak2
Copy link
Author

I removed ruby 2.0 and 2.1 from tests on Travis because actionpack (>= 5.0) was resolved to 5.1.4, which depends on ruby (>= 2.2.2)

@mmoll
Copy link

mmoll commented Nov 30, 2017

@mpapis @thejamespinto it would be very important for the Rails 5 migration of @theforeman that this fix goes in and a new gem release with it is crafted. ☝️

@ohadlevy
Copy link

ohadlevy commented Dec 4, 2017

@quirkey mind having a look? thank you!

@galois17
Copy link
Contributor

galois17 commented Dec 4, 2017

@ohadlevy once I get the rights to push up the gem. I can help out...

@ohadlevy
Copy link

ohadlevy commented Dec 4, 2017

@galois17 - I think we can start with merging this first :) and then cut a release. who should I ping after its merged for a release?

thanks!

This was referenced Dec 4, 2017
@ares
Copy link

ares commented Dec 7, 2017

Any chance this could get in anytime soon? I see @mpapis @charliesome @thejamespinto as authors of last commits, would you mind reviewing the PR?

@mpapis mpapis requested a review from ch1ago December 7, 2017 13:18
@mpapis
Copy link
Member

mpapis commented Dec 7, 2017

@galois17 you got the push rights on your email from GH

Copy link
Contributor

@galois17 galois17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

@galois17 galois17 merged commit ba97167 into ruby-oauth:master Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants