Skip to content

Conversation

@pboling
Copy link
Member

@pboling pboling commented Nov 7, 2025

- fixes #342
@pboling pboling self-assigned this Nov 7, 2025
Copilot AI review requested due to automatic review settings November 7, 2025 01:46
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Code Coverage

Package Line Rate Branch Rate Health
oauth 84% 54%
Summary 84% (836 / 1000) 54% (150 / 277)

Minimum allowed line rate is 81%

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.27%. Comparing base (fe2df2e) to head (52da944).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files          36       36           
  Lines        1062     1062           
  Branches      298      298           
=======================================
  Hits          895      895           
  Misses        167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the base64 gem as an explicit runtime dependency to ensure compatibility with Ruby 3.4 and 3.5 HEAD, where base64 is no longer a default gem but a bundled gem that must be explicitly required.

  • Adds base64 (~> 0.1) dependency to the gemspec with an explanatory comment about Ruby version compatibility
  • Updates Gemfile.lock to reflect the new dependency
  • Documents the change in CHANGELOG.md

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
oauth.gemspec Adds base64 (~> 0.1) as a runtime dependency with a comment explaining it became a bundled gem in Ruby 3.4
Gemfile.lock Reflects the addition of base64 dependency to the oauth gem specification
CHANGELOG.md Documents the new base64 dependency and its purpose for Ruby 3.4 and 3.5 HEAD compatibility
.rubocop_gradual.lock Updates line numbers for existing RuboCop offenses due to the added lines in oauth.gemspec

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pboling pboling merged commit 4b7e5fa into main Nov 7, 2025
40 checks passed
@pboling pboling deleted the fix/missing-base64-dep branch November 7, 2025 01:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19155553390

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.212%

Totals Coverage Status
Change from base Build 19155355042: 0.0%
Covered Lines: 836
Relevant Lines: 1000

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ruby 3.4 compatibility

3 participants