Fix nested hash params in Consumer#request posts #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Sorry to be a nuisance, but any word on this? |
Contributor
Author
|
Trying one more time -- any chance of this getting merged into an official release? Thanks! |
quirkey
added a commit
that referenced
this pull request
Sep 4, 2012
Fix nested hash params in Consumer#request posts
galois17
pushed a commit
to galois17/oauth-ruby
that referenced
this pull request
Oct 25, 2013
Fix nested hash params in Consumer#request posts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a situation recently in which oauth-ruby wasn't actually handling Rails-style nested parameters appropriately. The problem was that Net::HTTP only supports top-level params in its requests when set_form_data is used. Calling #to_params or #to_query on the Hash would cause the signature to fail validations. Using the normalize method from OAuth::Helper and setting the body and content_type directly (which is what set_form_data does) solves the problem.
Thanks!