Upgrade rubocop to version 0.56.0 #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
pboling
added
in Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've upgraded a dependency and all tests pass. \o/
You should probably take a good look at this before merging this pull request, of course.
What changed?
✳️ rubocop ( → 0.56.0) · Repo · Changelog
Release Notes
From the Github release:
New features
Performance/InefficientHashSearchcop. (@JacobEvelyn)Rails/RefuteMethodscop. (@koic)Rails/AssertNotcop. (@composerinteralia)Layout/ClosingParenthesisIndentationdetection including method chaining. (@jfelchner)consistent_relative_to_receiverstyle option toLayout/FirstParameterIndentation. (@jfelchner)AR::Migration#up_onlyforRails/ReversibleMigrationcop. (@koic)Lint/ErbNewArgumentscop. (@koic)Lint/SplatKeywordArgumentscop. (@koic)Include,Excludeand the newRubyInterpretersparameters for file selection. (@jonas054)Bug fixes
Style/EmptyMethodwhich concatenated the method name and first argument if no method def parentheses are used. (@thomasbrus)Rails/SaveBangwhen using negated if. (@Edouard-chin)Lint/SafeNavigationChainnot detecting chained operators after block. (@Darhazer)Lint/SafeNavigationConsistencyregisters multiple offenses for the same method call. (@rrosenblum)Style/CommentAnnotationreporting only the first of multiple consecutive offending lines. (@svendittmer)Lint/SafeNavigationConsistencywhen there is code around the condition. (@rrosenblum)Rails/HasManyOrHasOneDependentwhen using nestedwith_options. (@koic)--stdinalways treats input as Ruby source irregardless of filename. (@PointlessOne)Style/MethodCallWithArgsParenthesesadding extra parentheses if the method argument was already parenthesized. (@dvandersluis)AllCops/Includewere not inspected when passing the file name as an option. (@drenmi)Lint/PercentStringArrayandLint/PercentSymbolArraywhen the inspected file is binary encoded. (@akhramov)nilresponds to inLint/SafeNavigationConsistency. (@rrosenblum)Lint/LiteralInInterpolationif contains numbers. (@koic)Rails/CreateTableWithTimestampswhen using hash options. (@wata727)Lint/UnneededCopEnableDirectivefor instruction '# rubocop:enable all'. (@balbesina)Rails/HttpPositionalArgumnetsto usesessioninstead ofheader. (@rrosenblum)Changes
Style/MethodMissinginto two cops,Style/MethodMissingSuperandStyle/MissingRespondToMissing. (@rrosenblum)AllowInMultilineConditionsoption toStyle/ParenthesesAroundConditioncop. (@Darhazer)Layout/SpaceInsideReferenceBracketswhen assigning a reference bracket to a reference bracket. (@joshuapinter)--auto-correct. (@jonas054)try!to the list of whitelisted methods forLint/SafeNavigationChainandStyle/SafeNavigation. (@rrosenblum)Style/EmptyLineAfterGuardClausecop toLayoutdepartment. (@koic)Commits
See the full diff on Github. The new version differs by 60 commits:
Cut 0.56Fix `Rails/CreateTableWithTimestamps` when using hash options (#5868)[Fix #5708] Handle comment `rubocop:enable all` bug (#5810)Fix Style/MethodCallWithArgsParentheses autocorrect adding extra parens (#5825)Move `Style/EmptyLineAfterGuardClause` cop to `Layout`Add consistent_relative_to_receiver to FirstParameterIndentation (#5699)Fix Style/CommandLiteral autocorrection when %x is not configuredCleanup HttpPositionalArguments testsFix auto-correction of HttpPositionalArgs to use session instead of headerAdd new `Lint/SplatKeywordArguments` cop (#5871)Add spec for JSONLoad autocorrectFix bug in the examples of NodePattern documentationMake it easier to find writing custom cops guideAdd more tests for Lint/DuplicateMethodsRemove unused method from NestedPercentLiteralRemove unneeded `comment_on_line?` check[Fix #4247] Make all file inclusion lists configurableClarify GitHub account displayed by `rake new_cop`Correct Layout/EmptyLineBetweenDefs docs (#5852)Fix documentation for Rails/Present cop[Fix #5862] Fix incorrect autocorrect `Lint/LiteralInInterpolation`Move some cop options to config/default.ymlDon't concatenate method name and arguments in empty methods without method def parentheses[Fix #5082] Allow --auto-correct to use the cache when possible (#5857)Whitelist try! from safe navigation cops[Fix #5840] ignore methods that nil responds to in SafeNavigationConsistencyAdd Performance/InefficientHashSearch cop (#5848)[Fix #5800] Replace backtrace with --help suggestion for invalid options (#5816)Fix documentation typo[Fix #5809] Encoding bug in Lint/PercentStringArrayAdd new `Lint/ErbNewArguments` cop[Fix #5668] Fix an issue where included files weren't inspectedFix issue when reference brackets are assigned by reference brackets.Use expect_offense helpersRemove duplicate specsReduce line length (rubocop failure)Use faster string concatenationMemoize Dir.pwdUse incremental digesterUse shorter config string in digest[Fix #5819] Handle negated conditions in Rails/SaveBang (#5820)[Fix #5821] Support `AR::Migration#up_only` for `Rails/ReversibleMigration`CI against JRuby 9.1.17.0[Fix #5757] Add option to allow parentheses around multiline conditions[Fix #5789][Fix #4666] Fix STDIN filename handlingSplit Style/MethodMissing into Style/MethodMissingSuper and Style/MissingRespondToMissing (#5811)Add new `Rails/AssertNot` cop (#5805)Style: Make whitespace changesChange ClosingParenthesisIndentation error messages to be more preciseChange ClosingParenthesisIndentation to be relative to parameters[Fix #5713] Make `Style/CommentAnnotation` aware of inline comments (#5780)Add new `Rails/RefuteMethods` copFix broken link in Node Pattern docFix "No newline at end of file" of relnotesUpdate the copyright years in the manual[Fix #5784] Fix false positive for `Rails/HasManyOrHasOneDependent`[Fix #5791] Fix NoMethodError in SafeNavigationConsistency when there is code around the conditionRegister a single offense per method in SafeNavigationConsistency[Fix #5286] `Lint/SafeNavigationChain` not detecting chained operators after block.Improve description and examples of Performance/UnneededSortDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.