Specify version of minitest. Tests do not run on 2.0 otherwise. #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the report. Would it be possible to detect which version of minitest is installed and do the right thing? I'd rather not lock users into an older version of minitest if we don't have to. |
Contributor
Author
|
It's only a development dependency, not a runtime dependency. So it'd only affect developers, not users. |
skaes
pushed a commit
that referenced
this pull request
Nov 26, 2013
Specify version of minitest. Tests do not run on 2.0 otherwise.
Member
|
Indeed. We currently require minitest < 5.0. Thx for the help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to run unit tests on Ruby 2.0. I came across http://stackoverflow.com/questions/17461245/what-does-this-minitestunittestcase-warning-mean , suggesting that the error was due to using minitest 5.0 when the code was written for a previous version.
Without this change, no tests at all get run on Ruby 2.0.
Edit: actually, looks like the problem does not involve Ruby 2.0. It looks like it's just which version of minitest is being used.