Clean shutdown#224
Merged
liveh2o merged 2 commits intoruby-protobuf:3-3-stablefrom Oct 10, 2014
Merged
Conversation
Contributor
|
Seems reasonable to me. Any idea why Travis CI is failing? |
Contributor
Author
|
Looks related to setup on ruby 2.0
|
Contributor
|
Yeah, I saw that after I posted my comment. I just wanted to make sure we didn't break specs right after we got them all working again. |
Contributor
|
@localshred bump on this, it would be really nice to get released! |
Contributor
|
@liveh2o take another look - the reason the specs are passing here is because they're not really running at all. I fixed this on master some time ago. |
Contributor
|
That would explain why the specs started failing in 3-3-stable when I tried to pull in your spec fixes from master. I'll see what I can do. |
Contributor
|
Can you please unbreak master for the time being? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add resiliency against possible hanging on shutdown. The only change that's needed to resolve the cases we've seen is the addition of
exit 0to thecli.rb. The other modifications are preemptive fixes to other paths that could lead to a hanging shutdown.RFC @liveh2o @abrandoned @localshred