Abrandoned/broker probs#244
Merged
abrandoned merged 4 commits intomasterfrom Jan 17, 2015
Merged
Conversation
add functionality to recover from broker exception or not starting up correctly, will now wait for broker to start and will restart on crash
Contributor
|
Looks like a good enough cut. 👍 for refactoring this once it's extracted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move check available rcv/snd timeout on zeromq to use the ENV if specified (instead of if specified and greater than 200ms, that's a long time in socket connection)
In running the zeromq client/server the most common "failure" is when the broker either doesn't start or fails after running and the servers freezes. This PR adds a check in the running loop of the server to restart the broker if it fails, a new context is required to restart a failed broker.
I also removed the "ClassLength" check in rubocop as we are trying to get the zeromq stuff out of the mainline gem (which we can refactor at that time) and creating an abstraction to remove class length seems prone to creating the wrong abstractions if it is forced.
@localshred @liveh2o