-
Notifications
You must be signed in to change notification settings - Fork 96
Feature/graph transactions #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Transaction application will apply to Graph, so we are moving related methods into their own `RDF::Transactable` module.
Allow RDF::Graph to process write transactions.
|
LGTM other than comment. |
Certain aspects of `#isolation_level` don't apply to snapshots, but to snapshot + transaction. This peels the two apart somewhat. `Dataset` & `Repository` handle communicating the isolation level for `#snapshot`. The base `RDF::Transaction` defaults to `:read_committed`, but adheres to the snapshot's semantics if present. Generally, this will mean `:repeatable_read` or worse. The default Repository's `SerializedTransaction` assumes a snapshot, and is always `:serializable`.
|
A fix is in for See also: 3a6762e. Tests are, likewise, fixed at: ruby-rdf/rdf-spec#56 |
|
One thing to note is that these changes work slightly differently from inserting/deleting statements on a
This is roughly how things worked with |
|
Apart from my note about It doesn't close #269 until Transactional graph read is done. |
Maybe create an issue to track this. It is fairly useful to do an insert of an enumerable, as is done elsewhere. |
This implements write transactions for
RDF::Graph, partially fulfilling #269.Transactional read scoped to a Graph remains to be implemented.