Skip to content

Only use tx on #delete_insert for :atomic_write #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2016
Merged

Only use tx on #delete_insert for :atomic_write #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rdf/mixin/mutable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def delete_insert(deletes, inserts)
##
# Applies the given changeset
#
# If `#supports?(:transactions)` is `true`, this must apply the changeset
# If `#supports?(:atomic_write)` is `true`, this must apply the changeset
# atomically. Otherwise, it should offer an efficient implementation of a
# combined delete/insert of the changeset.
#
Expand Down
4 changes: 3 additions & 1 deletion lib/rdf/repository.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ def supports?(feature)
#
# @see RDF::Mutable#delete_insert
def delete_insert(deletes, inserts)
return super unless supports?(:atomic_write)

transaction(mutable: true) do
deletes.respond_to?(:each_statement) ? delete(deletes) : delete(*deletes)
inserts.respond_to?(:each_statement) ? insert(inserts) : insert(*inserts)
Expand Down Expand Up @@ -291,7 +293,7 @@ def each_statement(&block)
enum_statement
end
alias_method :each, :each_statement

##
# @see Mutable#apply_changeset
def apply_changeset(changeset)
Expand Down