Feature/tx query graph #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
That seems reasonable to me. Please be sure SPARQL specs pass with this change, though. |
This changes the Transaction semantics to behave like Graph. Queryable is somewhat opinionated that inserting triples to a queryable should result in those triples being accessible through query. In light of this, the answer to #278 seems to be that graph scope must be symmetrical for read and write operations. That interpretation is implemented here.
no-reply
force-pushed
the
feature/tx-query-graph
branch
from
c742a9a to
332f8eb
Compare
Member
Author
|
Fixed up the specs, squashed out the ruby-rdf/rdf-spec#59 is the corresponding spec update. A local run of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would close #269 and #278. The failing specs in CI call out a pre-existing issue with RDF::Graph's Queryable support that needs to be resolved before merge.
This changes the Transaction semantics to behave like Graph. Queryable is somewhat opinionated that inserting triples to a queryable should result in those triples being accessible through query. In light of this, the answer to #278 seems to be that graph scope must be symmetrical for read and write operations. That interpretation is implemented in the PR.
The remaining blocker is: Queryable's shared examples require a query pattern's graph name to be retained when querying, but Graph overwrites it.
My inclination is to change the specs (skip when
#graph_nameis defined), keeping the existing behavior. Thoughts, @gkellogg?