Fix RDF::List#== comparisons to RDF::Values #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2016 15:26
Ruby 2.3.0 changed the behavior of [`Comparable#==`](https://bugs.ruby-lang.org/issues/7688) to avoid hiding errors. This led to `NoMethodError`s for comparisons that return `false` for previous Rubies. This introduces a custom `RDF::List#==` implementation for explicitly supported comparisons between `RDF::Value` classes. We return `false` immediately for `RDF::Value`s which are not `#list?`; falling back on `Comparable` for other types. Further, `RDF::List`s with three elements that happen to coincide with the terms of an RDF::Statement would previously return `true`. E.g.: `RDF::List[:s, :p, :o] == RDF::Statement(:s, :p, :o)`. This unusual edge case is patched by way of the changes described above. Closes #304
Similar to the change for #304, an `RDF::List` containing the terms of a Statement was evaluated as equal by `Statement#==`. This makes a change to preserve symmetry of the `#==` relation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.3.0 changed the behavior of
Comparable#==to avoid hiding errors. This led toNoMethodErrors for comparisons that returnfalsefor previous Rubies.This introduces a custom
RDF::List#==implementation for explicitly supported comparisons betweenRDF::Valueclasses. We returnfalseimmediately forRDF::Values which are not#list?; falling back onComparablefor other types.Further,
RDF::Lists with three elements that happen to coincide with the terms of an RDF::Statement would previously returntrue. E.g.:RDF::List[:s, :p, :o] == RDF::Statement(:s, :p, :o). This unusual edge case is patched by way of the changes described above.A similar change is made to
RDF::Statement#==to preserve symmetry.Closes #304