Skip to content

Fix typo #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ko1 merged 1 commit into from
Nov 4, 2021
Merged

Fix typo #363

ko1 merged 1 commit into from
Nov 4, 2021

Conversation

@sampatbadhe
Copy link
Contributor

@sampatbadhe sampatbadhe commented Nov 3, 2021

No description provided.

@ono-max
Copy link
Member

ono-max commented Nov 3, 2021 •
edited
Loading

Could you update misc/README.md.erb and run $ bundle exec rake README.md?

FYI: https://github.com/ruby/debug/blob/master/CONTRIBUTING.md#to-update-readme

@ono-max
Copy link
Member

ono-max commented Nov 3, 2021 •
edited
Loading

Oh, it sounds that you updated it already because the part in README is generated from session.rb, not misc/README.md.erb. Never mind 👍

@sampatbadhe
Copy link
Contributor Author

sampatbadhe commented Nov 3, 2021

Yes @ono-max, Thank you for the review.

@ko1 ko1 merged commit 8aa8b10 into ruby:master Nov 4, 2021
@sampatbadhe sampatbadhe deleted the fix-typo branch November 19, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ono-max ono-max ono-max approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sampatbadhe @ono-max @ko1