Skip to content

Conversation

@st0012
Copy link
Member

@st0012 st0012 commented Jan 11, 2022

omit provides cleaner messages.

pend

=====================================================================================================================================================================================================================================================================================================================================================
Pending: test_break_works_correctly(DEBUGGER__::BreakTest1638674577): Tests for DAP were skipped. You can enable them with RUBY_DEBUG_DAP_TEST=1.
/Users/st0012/projects/debug/test/support/dap_utils.rb:168:in `run_dap_scenario'
test/dap/break_test.rb:21:in `test_break_works_correctly'
     18:     RUBY
     19:
     20:     def test_break_works_correctly
  => 21:       run_dap_scenario PROGRAM do
     22:         [
     23:           *INITIALIZE_MSG,
     24:           {
=====================================================================================================================================================================================================================================================================================================================================================

omit

=====================================================================================================================================================================================================================================================================================================================================================
Omission: Tests for DAP were skipped. You can enable them with RUBY_DEBUG_DAP_TEST=1. [test_break_works_correctly(DEBUGGER__::BreakTest1638674577)]
/Users/st0012/projects/debug/test/support/dap_utils.rb:168:in `run_dap_scenario'
=====================================================================================================================================================================================================================================================================================================================================================

(inspiration: ruby/net-http@843d4548de)

`omit` provides cleaner messages.

**pend**

```
=====================================================================================================================================================================================================================================================================================================================================================
Pending: test_break_works_correctly(DEBUGGER__::BreakTest1638674577): Tests for DAP were skipped. You can enable them with RUBY_DEBUG_DAP_TEST=1.
/Users/st0012/projects/debug/test/support/dap_utils.rb:168:in `run_dap_scenario'
test/dap/break_test.rb:21:in `test_break_works_correctly'
     18:     RUBY
     19:
     20:     def test_break_works_correctly
  => 21:       run_dap_scenario PROGRAM do
     22:         [
     23:           *INITIALIZE_MSG,
     24:           {
=====================================================================================================================================================================================================================================================================================================================================================
```

**omit**

```
=====================================================================================================================================================================================================================================================================================================================================================
Omission: Tests for DAP were skipped. You can enable them with RUBY_DEBUG_DAP_TEST=1. [test_break_works_correctly(DEBUGGER__::BreakTest1638674577)]
/Users/st0012/projects/debug/test/support/dap_utils.rb:168:in `run_dap_scenario'
=====================================================================================================================================================================================================================================================================================================================================================
```
@ono-max
Copy link
Member

ono-max commented Jan 22, 2022

Nice.
LGTM.

@ko1 ko1 merged commit 089ae90 into ruby:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants