fix: exclude some files from published gem#108
Conversation
|
I think it would be good to also exclude |
erb.gemspec
Outdated
| `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } | ||
| spec.files = Dir.chdir(__dir__) do | ||
| `git ls-files -z`.split("\x0").reject do |f| | ||
| (f == __FILE__) || f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)}) |
There was a problem hiding this comment.
| (f == __FILE__) || f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)}) | |
| f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)}) |
Can we keep gemspec? Even if it's not used and doesn't have any version-specific information, I would like to see its existence for extra confidence when debugging a gem installation.
Other projects I work on generally ship the file. Even Prism, which explicitly lists up everything, keeps it. It just seems too extreme to explicitly get rid of it for saving such a small size.
There was a problem hiding this comment.
Also I guarantee you we won't use AppVeyor or Travis CI ever again, so let's not mention it.
I just applied it and cleaned it up dc7bf9b.
Yeah, not worth it. Let's stop deleting everything for saving some KBs. |
(ruby/erb#108) ruby/erb@2fd0a6b71c Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
2 participants
Currently the published gem includes the
.githubdirectory which is 32kb we don't need - I've updated the files check to use whatbundlergenerates nowdays