FileUtils.remove_dir checks directory #132
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unsure this can cause severe compatibility issues. |
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Jul 25, 2025
Some of our tests use
```ruby
let(:temporary_directory) { "does/not/exist" }
```
and in ruby/fileutils#132 the behavior of
`FileUtils.remove_dir` was tweaked to change the exception that gets
raised when doing `FileUtils.remove_dir` with a directory that doesn't
exist.
I've updated the test clean-up hook with the new exception as well.
dd-mergequeue bot
pushed a commit
to DataDog/libdatadog
that referenced
this pull request
Jul 25, 2025
* Fix specs failing due to slightly changed behavior on ruby-master
Some of our tests use
```ruby
let(:temporary_directory) { "does/not/exist" }
```
and in ruby/fileutils#132 the behavior of
`FileUtils.remove_dir` was tweaked to change the exception that gets
raised when doing `FileUtils.remove_dir` with a directory that doesn't
exist.
I've updated the test clean-up hook with the new exception as well.
* Minor: Add `irb` to development dependencies
May come in handy sometimes (and does not affect what we ship to
customers).
* Minor: Refresh rspec configuration
As per https://ivoanjo.me/blog/2016/09/25/why-you-should-regenerate-your-spec-helper/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
FileUtils.remove_diris passed a directory. Add a unit test verifying thatErrno::ENOTDIRis raised when callingremove_diron a non-directory/file.This may cause some existing "working" programs to error, but in a way that prevents users from accidentally deleting files, which seems like a safer approach than allowing the program to delete the file and continue running.
Removes FIXME added in 2005 by @aamine.