Load extension ('json/ext') consistently in test_ext #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patch fixes the issue that
rake testdoes not actually testC extension for CRuby.
The Bug
The
testtask is defined as follows:https://github.com/flori/json/blob/7ec73ad240d45018f119f5d1a2eaa479ad3f9038/Rakefile#L109-L110
This invokes
:test_pureand:test_extconsecutively.:test_pureassignsENV['JSON'] = 'pure'as follows:https://github.com/flori/json/blob/7ec73ad240d45018f119f5d1a2eaa479ad3f9038/Rakefile#L97-L98
However,
:test_extfor CRuby does not changeENV['JSON'].https://github.com/flori/json/blob/7ec73ad240d45018f119f5d1a2eaa479ad3f9038/Rakefile#L252
This lead to
require 'json/pure'in test_helper.rb, which test only the pure version.https://github.com/flori/json/blob/7ec73ad240d45018f119f5d1a2eaa479ad3f9038/tests/test_helper.rb#L2-L4
How to Fix It
I have added
:set_env_extto guarantee that:test_extassignsENV['JSON'] = 'ext'.This is just like
test_extin JRuby version