Fix an error when specify --define=foo

[ydah]

❯ exe/lrama --define=foo sample/calc.y
wrong array length at 0 (expected 2, was 1)

This is occurring and has been addressed below:

lrama/lib/lrama/grammar.rb

Line 60 in 7fa74d8

@define = define.map {|d| d.split('=') }.to_h

[yui-knk]

I'm not sure why steep didn't warn however please update type declaration too.

lrama/sig/lrama/options.rbs

Line 4 in 7fa74d8

attr_accessor define: Hash[String, String]

[yui-knk]

[Note] It seems steep 1.9.3 doesn't warn on array assignment to Hash type instance variable:

# code
@define = []

# rbs
attr_accessor define: Hash[String, String]

$ bundle exec steep check
# Type checking files:

......................................................................................................................

No type error detected. 🫖

but it warns on hash assignment to Array type instance variable:

# code
@define = {}

# rbs
attr_accessor define: Array[String]

$ bundle exec steep check
# Type checking files:

.....................................................................F................................................

lib/lrama/options.rb:15:16: [warning] Empty hash doesn't have type annotation
│ Diagnostic ID: Ruby::UnannotatedEmptyCollection
│
└       @define = {}
                  ~~

Detected 1 problem from 1 file

[junk0612]

This change alone is probably not sufficient, and changes are needed, for example, in the location of the assignment at below.

lrama/parser.y

Line 28 in 7fa74d8

| "%define" variable value { @grammar.define[val[1].s_value] = val[2]&.s_value }

By the way, I think Hash is appropriate for define because it is written in the grammar file as %define lr.type ielr or from the command line as lrama -D lr.type=ielr, but why change it to Array?

[ydah]

This change alone is probably not sufficient, and changes are needed, for example, in the location of the assignment at below.

Changes there will be made separately. Certainly as it is now, if a value is missing, it will result in an error.

By the way, I think Hash is appropriate for define because it is written in the grammar file as %define lr.type ielr or from the command line as lrama -D lr.type=ielr, but why change it to Array?

I didn't mean to change the @define to Array in the first place. Because, below, I am converting from Array to Hash. It looks like the intended code.

lrama/lib/lrama/grammar.rb

Line 60 in 7fa74d8

@define = define.map {|d| d.split('=') }.to_h

This PR simply changes the default value from Hash to Array.
Because the following Option is received in Array.

lrama/lib/lrama/option_parser.rb

Line 63 in 968725e

o.on('-D', '--define=NAME[=VALUE]', Array, "similar to '%define NAME VALUE'") {|v| @options.define = v }

If I understand something incorrectly, please point it out to me.

[ydah]

I changed it back to Hash to avoid the error 569f568
And moved to rbs-inline style type definition 4bd35c0

[junk0612]

I didn't mean to change the @define to Array in the first place. Because, below, I am converting from Array to Hash. It looks like the intended code.

I see, indeed. My understanding was wrong.