Fix nested parameterized rule calls in subsequent args position#779
Merged
ydah merged 1 commit intoruby:masterfrom Mar 1, 2026
Merged
Fix nested parameterized rule calls in subsequent args position#779ydah merged 1 commit intoruby:masterfrom
ydah merged 1 commit intoruby:masterfrom
Conversation
`parameterized_args` only supported nested rule calls (e.g.
`f_opt(number)`) as the **first** argument. Subsequent arguments after
a comma could only be bare symbols, causing a parse error when using
`args_list(f_opt(number), opt_tail(string), number)`.
Add the missing production to handle `IDENTIFIER "(" parameterized_args ")"` after a comma, mirroring the existing first-arg production.
ydah
force-pushed
the
fix-nested-parameterized_rule
branch
from
998eace to
cabceee
Compare
yui-knk
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parameterized_argsonly supported nested rule calls (e.g.f_opt(number)) as the first argument. Subsequent arguments after a comma could only be bare symbols, causing a parse error when usingargs_list(f_opt(number), opt_tail(string), number).Add the missing production to handle
IDENTIFIER "(" parameterized_args ")"after a comma, mirroring the existing first-arg production.