[DOC] Define path for examples #109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
peterzhu2118
left a comment
peterzhu2118
left a comment
There was a problem hiding this comment.
I'm not sure what the purpose of this PR is. Why do we need a path for the URI?
Member
Author
It will be needed for some changes to either header.rb or http.rb (I forget which). I'll be replacing some schema-like examples with actual executable code, which will require a path. I just put this up first b/c it's small and simple. |
Member
|
I would prefer to have all the changes in a single PR so that I can see the motivation of this change. I can't see the benefits of this change so it's hard for me to give a meaningful review. |
Member
Author
|
Will be rolled into a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.