Conversation
nevans
commented
Feb 13, 2026
Adding colors makes it much faster/easier for me to read and understand detailed debug messages. Of all the exception classes in net-imap, this one benefits the most from some extra formatting, IMO. When `ENV["NO_COLOR"]` is not empty, highlights are monochromatic by default (only uses bold and underline).
Iterating on the prior highlighting approach, this a tidy solution to the problem of only resetting what needs to be reset. Specifically, I'd like to add color highlighting, while keeping the NO_COLOR highlighting, and I don't want to add a bunch of redundant reset sequences. This is still annoyingly complex (and adding ractor support makes it much worse), but I think it still comes out as simpler than the other approaches I looked at.
This adds more distinct highlighting types, for color highlighting. Monochrome highlighting simply ignores types it hasn't defined.
nevans
force-pushed
the
response_parse_error-detailed_message-color-highlights
branch
from
217f9da to
8ed8949
Compare
nevans
deleted the
response_parse_error-detailed_message-color-highlights
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding colors makes it much faster/easier for me to read and understand detailed debug messages. Of all the exception classes in net-imap, this one benefits the most from some extra formatting, IMO.
When
ENV["NO_COLOR"]is not empty, highlights are monochromatic by default (only uses bold and underline).