Conversation
kddnewton
left a comment
There was a problem hiding this comment.
One small change and then great! Thanks!
kddnewton
left a comment
There was a problem hiding this comment.
I think this might be more complicated than this unfortunately.
If you get it {} I think it needs to change back into a method call. This is also the case for when it receivers arguments without parentheses.
|
I tried some of such cases with local |
aba26bd to
fa16d06
Compare
We've fixed all cases except for pattern matching => ^it. Do we want to address it in this PR, or could that be a separate PR?
kddnewton
left a comment
There was a problem hiding this comment.
I think we should add => ^it in this PR. Also we will need to document that the local variable read nodes for it will actually use 0it for the constant name, since that's pretty weird.
Co-authored-by: Kevin Newton <kddnewton@gmail.com>
close #2052