Remove flag gating for 3.3.0 bug fixes#2200
Merged
Conversation
enebo
reviewed
Jan 17, 2024
| pm_index_target_node_t *node = PM_ALLOC_NODE(parser, pm_index_target_node_t); | ||
| pm_node_flags_t flags = target->base.flags; | ||
|
|
||
| if (parser->version != PM_OPTIONS_VERSION_CRUBY_3_3_0) { |
Collaborator
There was a problem hiding this comment.
I know this gating was removed but I wonder if we want inequality for this by default with specific equality when it is locked to something specific.
parser->version >= PR_OPTIONS_VERSION_CRUBY_3_3
It is pretty likely we will see ranges doing <= and >= if something appears then is removed later. Just a drive-by comment.
Collaborator
Author
There was a problem hiding this comment.
That makes sense - I'll keep that in mind going forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2163