Draft
Conversation
* JAVA_STRING_TYPE and related change to IDENTIFIER * TruffleRuby still uses java.lang.String Fixes ruby#4009
headius
force-pushed
the
byte_ary_identifiers
branch
from
a1d2677 to
a0aae26
Compare
eregon
approved these changes
Mar 19, 2026
| return new String(bytes, encodingCharset).intern(); | ||
| <%- else -%> | ||
| return null; // Must be implemented by subclassing Loader | ||
| return bytes; // Must be implemented by subclassing Loader |
Member
There was a problem hiding this comment.
Suggested change
| return bytes; // Must be implemented by subclassing Loader | |
| return bytes; |
Contributor
Author
|
This is still a draft and needs to be integrated into JRuby so I know if it's working properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To remove the compile-time dependency on JRuby in the Java API, we need to replace RubySymbol identifiers with something implementation-independent. The simplest option is to use the original identifier bytes (byte[]).
Fixes #4009.