Skip to content

Remove useless condition check #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

Remove useless condition check #636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions lib/rake/thread_pool.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,19 +108,13 @@ def process_queue_item #:nodoc:
false
end

def safe_thread_count
@threads_mon.synchronize do
@threads.count
end
end

def start_thread # :nodoc:
@threads_mon.synchronize do
next unless @threads.count < @max_active_threads

t = Thread.new do
begin
while safe_thread_count <= @max_active_threads
loop do
break unless process_queue_item
end
ensure
Expand Down