Skip to content

Fix contributing documentation: install "hoe" gem dependency#78

Merged
hsbt merged 2 commits intoruby:masterfrom
pvdb:fix_contributing_documentation
Oct 21, 2015
Merged

Fix contributing documentation: install "hoe" gem dependency#78
hsbt merged 2 commits intoruby:masterfrom
pvdb:fix_contributing_documentation

Conversation

@pvdb
Copy link
Copy Markdown
Contributor

@pvdb pvdb commented Oct 20, 2015

@hsbt et al. - I'm submitting a minor "documentation fix" for the CONTRIBUTING.rdoc file, which didn't include instructions for installing the "hoe" gem dependency.

It's a bit off-putting for newbies to follow the instructions, only to get the following error message when running rake newb in a Ruby environment in which the "hoe" gem hasn't been previously installed:

$ rake newb
rake aborted!
LoadError: cannot load such file -- hoe
/Users/pvdb/Workarea/pvdb/rake/Rakefile:18:in `<top (required)>'
(See full trace by running task with --trace)
$ _

@hsbt
Copy link
Copy Markdown
Member

hsbt commented Oct 21, 2015

Good catch! I often missed gem installe hoe with new environment too.

Thanks.

hsbt added a commit that referenced this pull request Oct 21, 2015
@hsbt
Merge pull request #78 from pvdb/fix_contributing_documentation
11be647 
Fix contributing documentation: install "hoe" gem dependency
@hsbt hsbt merged commit 11be647 into ruby:master Oct 21, 2015
@hsbt hsbt mentioned this pull request Oct 21, 2015
Closed
@pvdb
Copy link
Copy Markdown
Contributor Author

pvdb commented Oct 21, 2015

Cheers, @hsbt, thanks for accepting the PR into rake!

@pvdb pvdb deleted the fix_contributing_documentation branch October 21, 2015 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pvdb @hsbt