bin/sort is broken

[pocke]

• It is not aware of constants in the class definition
• It changes method visibility

We can fix the first problem easily. We just need to add a when clause to group method.

The second problem is more difficult. Currently bin/sort brings up all private and public members. For example:

class C
  private
  def foo: -> void
  public
  def bar: -> void
end

# by bin/sort ↓

class C
  private

  public
  def bar: () -> void
  def foo: () -> void
end

So it should be aware of method visibility. I have two solution ideas.

• List all public methods, then list all private methods.
• Use private def foo ... syntax for all private methods.

The contribution guide mentions this script, so we should fix the problem, and the script should print the "standard" style of RBS.

[pocke]

The order of members/decls should be the following. The leading comments are priorities for #sort. In the same priority, the items are sorted alphabetically.

class C
  type t = String              # -3

  CONSTANT = 42                # -2

  class Klass                  # -1
  end
  module Mod                   # -1
  end

  include M                    # 0
  prepend M                    # 0.2
  extend M                     # 0.4

  @@cvar: String               # 1

  self.@civar: String          # 2

  @ivar: String                # 3

  def self?.foo: () -> void    # 4

  attr_accessor self.a: String # 5.0
  attr_reader self.b: String   # 5.0
  attr_writer self.c: String   # 5.0

  def self.new: () -> instance # 5.2

  def self.foo: () -> void     # 5.4
  alias self.x self.y          # 5.4

  private                      # ???

  attr_accessor self.a: String # 5.6

  def self.foo: () -> void     # 5.8

  public                       # ???

  attr_accessor a: String      # 6
  attr_reader b: String        # 6
  attr_writer c: String        # 6

  def initialize: () -> void   # 6.2

  def foo: () -> void          # 6.4
  alias x y                    # 6.4

  private

  attr_accessor a: String      # 6.6

  def foo: () -> void          # 6.8
end

I think all private and public prefixes should be omitted.

This script just defines the coding style for ruby/rbs internal, but does not define the community standard.