[Writer] Preserve an empty line between declarations and members#146
Merged
soutaro merged 2 commits intoruby:masterfrom Dec 30, 2019
Merged
[Writer] Preserve an empty line between declarations and members#146soutaro merged 2 commits intoruby:masterfrom
soutaro merged 2 commits intoruby:masterfrom
Conversation
e37e399 to
d29d023
Compare
d29d023 to
1e694ca
Compare
soutaro
reviewed
Dec 30, 2019
|
|
||
| end | ||
|
|
||
| def test_smoke |
Member
|
@pocke Thanks! |
tk0miya
added a commit
to tk0miya/rbs
that referenced
this pull request
Sep 16, 2024
ruby#146 adds preservation empty lines between declarations feature to the classes. This also introduces the same feature to the modules. Now our writer inserts a line to between all declarations. It's a bit difficult to read. Therefore, this increase the readability of the generated RBS files.
tk0miya
added a commit
to tk0miya/rbs
that referenced
this pull request
Sep 16, 2024
ruby#146 added preservation empty lines between declarations feature to the classes. This also introduces the same feature to the modules. Now our writer inserts a line to between all declarations. It's a bit difficult to read. Therefore, this increase the readability of the generated RBS files.
tk0miya
added a commit
to tk0miya/rbs
that referenced
this pull request
Sep 16, 2024
ruby#146 added preservation empty lines between declarations feature to the classes. This also introduces the same feature to the modules. Before this change, our writer inserts a line to between all declarations. It's a bit difficult to read. Therefore, this increases the readability of the generated RBS files.
tk0miya
added a commit
to tk0miya/rbs
that referenced
this pull request
Sep 16, 2024
ruby#146 added preservation empty lines between declarations feature to the classes. This also introduces the same feature to the modules. Before this change, our writer inserts a line to between all declarations. It's a bit difficult to read. Therefore, this increases the readability of the generated RBS files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By this change, the writer will preserve an empty line between declarations and members.
I also added a smoke test for
Ruby::Signature::Writer.It only checks the writer generates the same meaning signature.
Format examples
no changes
also no changes
But it removes too many empty lines. the following code will be formatted to the same as the previous example.