Skip to content

Fix stack overflow while resolving included module by ConstantTable #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soutaro merged 1 commit into from
Dec 31, 2019
Merged

Fix stack overflow while resolving included module by ConstantTable #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ruby/signature/constant_table.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def constant_scopes_module(name, scopes:)
decl.members.each do |member|
case member
when AST::Members::Include
constant_scopes_module absolute_type_name(name, namespace: namespace),
constant_scopes_module absolute_type_name(member.name, namespace: namespace),
Copy link
Member

@soutaro soutaro Dec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

scopes: scopes
end
end
Expand Down
11 changes: 11 additions & 0 deletions test/ruby/signature/constant_table_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,12 @@ def test_reference_constant_inherit_module
class Set
end

module Baz
end
Baz::X: Integer

module Foo::Bar
include Baz
end
EOF
manager.build do |env|
Expand All @@ -139,6 +144,12 @@ module Foo::Bar
assert_equal "::Set", constant.name.to_s
assert_equal 'singleton(::Set)', constant.type.to_s
end

table.resolve_constant_reference(TypeName.new(name: :X, namespace: Namespace.empty), context: Namespace.parse("::Foo::Bar")).tap do |constant|
assert_instance_of Constant, constant
assert_equal "::Baz::X", constant.name.to_s
assert_equal '::Integer', constant.type.to_s
end
end
end
end
Expand Down