Skip to content

Rename test_polar methods in Complex_test to avoid conflicting#166

Merged
soutaro merged 1 commit intoruby:masterfrom
pocke:merge-duplicated-test
Jan 3, 2020
Merged

Rename test_polar methods in Complex_test to avoid conflicting#166
soutaro merged 1 commit intoruby:masterfrom
pocke:merge-duplicated-test

Conversation

@pocke
Copy link
Member

@pocke pocke commented Jan 3, 2020

No description provided.

@soutaro
Copy link
Member

soutaro commented Jan 3, 2020

@pocke Could you rename the first test_polar method? The first one is to test polar singleton method and the second one is to test polar instance method. I think keeping both of them makes sense, and test_singleton_polar, test_instance_polar, or something else would be a good name.

@pocke pocke force-pushed the merge-duplicated-test branch from 0ed8797 to bb0bbd0 Compare January 3, 2020 15:38
@pocke
Copy link
Member Author

pocke commented Jan 3, 2020

Make sense. I renamed them and force-pushed the change.
Thanks!

@pocke pocke changed the title Merge duplicated test cases in Complex_test.rb Rename test_polar methods in Complex_test to avoid conflicting Jan 3, 2020
@soutaro soutaro merged commit cc063aa into ruby:master Jan 3, 2020
@pocke pocke deleted the merge-duplicated-test branch January 4, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants