Merged
Conversation
Member
|
I'd suggest adding a simple test for the task, like running |
Member
Author
soutaro
reviewed
Jun 27, 2020
| bin/setup | ||
| bundle exec rake | ||
| bundle exec rake build | ||
| RBS_GENERATE_TEST_PATH=/tmp/Array_test.rb bundle exec rake 'generate:stdlib_test[Array]' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains several fixes for
generate:stdlib_testrake task.First, it raises an error for accessing unknown constant.
Because it requires
rbslibrary but it accesses toRuby::Signatureconstant.So I replaced
Ruby::SignaturewithRBS.Second, it generates the old-style test cases, which uses
StdlibTest. So I replaced it with the new style test cases.Third, it isn't aware of libraries. It means the generator does not work for the standard libraries. For example,
rake generate:stdlib_test[Pathname]doesn't work.So I updated the generator to load all standard libraries.
It also loads unnecessary libraries, but I think it is the easiest way.