Merged
Conversation
Member
|
I'm not sure if having expanded definitions makes sense. So, your definition looks ok! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes
Kernel#ptype.Currently the return value is typed as NilClass, but actually it returns the argument type.
But, I think this proposed type is not the best way. Because it is too loose for multiple arguments.
I'm not sure we can write the return value type. But I have a compromise idea with a limited number of arguments.
It works correctly if the arguments are less than 8.
If you'd like the idea, I'll apply it to this pull request. If you have any idea to write the type with a more cool code, please tell me it!
Thanks.