-
Notifications
You must be signed in to change notification settings - Fork 445
Add AGENTS.md and CLAUDE.md to the project #1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Preview deployment available at: https://dcd4282f.rdoc-6cd.pages.dev (commit: 886b68d) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor suggestions and questions
|
|
||
| **Configuration:** `.rubocop.yml` | ||
|
|
||
| - Target Ruby: 3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kind of contradicts the other Ruby version requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's simply stating the RuboCop uses Ruby 3.0's syntax to lint the code, which can affect the result. This IMO doesn't contradict with the fact that at runtime we have to make it compatible with Ruby 2.6.
| ## Common Workflows | ||
|
|
||
| Do NOT commit anything. Ask the developer to review the changes after tasks are finished. | ||
|
|
||
| NEVER pushes code to any repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these necessary? Do we see agents trying to commit and push? 😨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this happened to me once due to testing a copy-pasted user-level command instruction 😅
And honestly, I want to make sure anyone contributing to RDoc using AI at least committing (and hopefully reviewing the code) by themselves.
f234e00 to
aeff50a
Compare
I've been using AI coding agents to assist my development in RDoc for a while. And having these instructions can save me (or anyone who wants to contribute) quite a bit of time.
AGENTS.mdis what most agentic tools use, such as OpenAI Codex or Cursor.CLAUDE.mdis only for Claude Code, which is the main tool I use.