[Aliki] Adjust table of content scrollable area height #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
Collaborator
|
🚀 Preview deployment available at: https://037fc629.rdoc-6cd.pages.dev (commit: a9e975a) |
st0012
approved these changes
Nov 19, 2025
| aside.table-of-contents .toc-sticky { | ||
| display: flex; | ||
| flex-direction: column; | ||
| height: calc(100vh - var(--layout-header-height) - var(--space-8) * 2); |
Member
There was a problem hiding this comment.
Can you add a comment explaining this calculation?
tompng
force-pushed
the
toc_scroll_height
branch
from
a9e975a to
b575546
Compare
tompng
requested a deployment
to
fork-preview-protection
GitHub Actions
Waiting
st0012
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aside.table-of-contents .toc-sticky navhadheight: calc(100vh - var(--layout-header-height))but height should exclude padding and height of
<h3>On This Page</h3>element.This calculation is hard, so I use display:flex instead.
Left: before, Right: after
Scenario: scroll to page bottom
Left: before, Right: after