Rebuild Aliki's searching mechanism #1504
Conversation
|
🚀 Preview deployment available at: https://5ad0d5cc.rdoc-6cd.pages.dev (commit: f4a8cdf) |
|
|
||
| if (isNamespaceQuery) { | ||
| // For namespace queries like "Foo::B", match against full_name | ||
| if (!fullNameLower.startsWith(queryLower)) { |
There was a problem hiding this comment.
Query that contains # should also match against full_name.
For example, Array#filter should match to something but currently it doesn't.
(Search with filter in ruby/ruby's doc and press down arrow will fill Array#filter to the search form.)
| matchScore = 100; | ||
| } else { | ||
| // For regular queries, match against unqualified name (prefix match) | ||
| if (!nameLower.startsWith(queryLower)) { |
There was a problem hiding this comment.
I often search methods that includes query in IRB, like:
Kernel.methods.grep /_defined\?/
Can we include substring match? and prioritize lower than prefix match.
|
I don't think the current search is bad, except for the search result order and constant not searched. How about first match against full_name with regexps generated by the old searcher, and then reorder the result with score? |
Rebuild Aliki's search mechanism with a custom search index and improved ranking algorithm.
Key changes:
js/search_data.js) instead of using the shared JsonIndex generator (can be removed along with Darkfish in the future)Closes #1497