Make sure path link in footers work correctly #1508
Merged
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🚀 Preview deployment available at: https://7fc5f247.rdoc-6cd.pages.dev (commit: ea50b1a) |
vinistock
reviewed
Dec 18, 2025
|
|
||
| def resolve_url(rel_prefix, url) | ||
| uri = URI.parse(url) | ||
| if uri.absolute? |
Collaborator
There was a problem hiding this comment.
Can a URI ever not be absolute? I thought parsing a URI for a relative path always failed.
Member
Author
There was a problem hiding this comment.
Yeah you can create URI with a wide range of strings:
irb(main):005> URI.parse("/foo")
=> #<URI::Generic /foo>
irb(main):006> URI("/foo")
=> #<URI::Generic /foo>
irb(main):007> URI("foo")
=> #<URI::Generic foo>
irb(main):008> URI("foo").absolute?
=> false
irb(main):009> URI("/foo").absolute?
=> false
irb(main):010> URI("foobar?baz>").absolute?
=> false
Collaborator
There was a problem hiding this comment.
Ah, right. I think the limitation is with file URIs.
We use URIs for files so often for tooling stuff I forget there are other URIs 😅
vinistock
approved these changes
Dec 18, 2025
|
|
||
| def resolve_url(rel_prefix, url) | ||
| uri = URI.parse(url) | ||
| if uri.absolute? |
Collaborator
There was a problem hiding this comment.
Ah, right. I think the limitation is with file URIs.
We use URIs for files so often for tooling stuff I forget there are other URIs 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1498