-
Notifications
You must be signed in to change notification settings - Fork 447
Fix class/module alias document having wrong name #1515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Preview deployment available at: https://fdc86876.rdoc-6cd.pages.dev (commit: dc4d1a1) |
4e58ee5 to
cb5203f
Compare
| assert_equal [@klass_alias, @ignored, @klass, @object], | ||
| assert_equal %w[Ignored Klass Klass::A Object], | ||
| [@ignored, @klass, @klass_alias, @object].map(&:full_name) | ||
| assert_equal [@ignored, @klass, @klass_alias, @object], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add one of these tests to Aliki’s generator test as well?
| cm_alias.parent = self | ||
| cm_alias.full_name = nil # force update for new parent | ||
| end | ||
| cm_alias.full_name = nil # force update for new parent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a ClassModule/CodeObject level test to prevent regression too?
Stop aliased class/module document file overwrite original one. Fix aliasing-to-toplevel check.
cb5203f to
dc4d1a1
Compare
Fixes #1014
Some aliased class/module document had wrong title.
Example: https://docs.ruby-lang.org/en/master/Net/HTTP.html
Title should be
class Net::HTTP, Notclass Net::HTTPSession.RDoc first generates
Net/HTTP.htmlwith the correct content, and then overwrite the same file with aliased-name content.Fixes:
Documents of
ruby/rubythat will change: