Change sidebar hiding strategy to avoid flickering on mobile devices #1516
+13
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🚀 Preview deployment available at: https://97534c8f.rdoc-6cd.pages.dev (commit: 83c8d7a) |
Previously, the sidebar was hidden with JavaScript on small viewports. This approach caused flickering when the page was loaded, especially on mobile devices. Now, the sidebar is hidden by default with the `hidden` attribute. On large viewports, we display the sidebar with JavaScript. This approach avoids flickering when the page is loaded, especially on mobile devices.
st0012
force-pushed
the
avoid-sidebar-flickering-on-mobile
branch
from
5357c91 to
83c8d7a
Compare
tompng
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the sidebar was hidden with JavaScript on small viewports. This approach caused flickering when the page was loaded, especially on mobile devices.
Now, the sidebar is hidden by default with the
hiddenattribute. On large viewports, we display the sidebar with JavaScript. This approach avoids flickering when the page is loaded, especially on mobile devices.