Make labels cross-browser compatible. #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atible.
Percent-encoded URL fragments prevent Firefox from jumping to their respective anchors. Wikipedia (MediaWiki) does something similar, with `.` instead of `-`.
There's precedent in `RDoc::{Alias,MethodAttr}#html_name` (54dbcf7) and `RDoc::Context::Section#aref` (431baa1). This breaks backwards-compatibility, though.
blackwinter
added a commit
to blackwinter/hen
that referenced
this pull request
Oct 24, 2014
Member
|
Thank you for your work on RDoc @blackwinter, I'll try to check into this one soon! Can you show a screenshot with steps to reproduce this? |
Contributor
Author
(Firefox 33.0 on Ubuntu Utopic) |
Member
|
Since these links only appear to work on chrome and safari I will commit it. |
drbrain
added a commit
that referenced
this pull request
Nov 26, 2014
…mpatible Make labels cross-browser compatible.
Contributor
Author
|
Thank you. |
blackwinter
added a commit
to blackwinter/hen
that referenced
this pull request
Dec 8, 2014
Implemented in RDoc 4.2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Percent-encoded URL fragments prevent Firefox from jumping to their respective anchors (see, e.g., RDoc's History.txt: None of those links in the table of contents work in Firefox). Wikipedia (MediaWiki) does something similar, with
.instead of-.There's precedent in
RDoc::{Alias,MethodAttr}#html_name(54dbcf7) andRDoc::Context::Section#aref(431baa1). This breaks backwards-compatibility, though.