Merged
Conversation
osyo-manga
force-pushed
the
refactoring-reline-core
branch
2 times, most recently
from
c474d31 to
b6066a4
Compare
osyo-manga
force-pushed
the
refactoring-reline-core
branch
from
b6066a4 to
6c02a85
Compare
Contributor
Author
|
@aycabta Please reviewing |
aycabta
suggested changes
Aug 21, 2019
Member
aycabta
left a comment
aycabta
left a comment
There was a problem hiding this comment.
Thank you for the great works! I'll merge after the requested changes.
lib/reline.rb
Outdated
|
|
||
| ATTR_ACCESSOR_NAMES = %i( | ||
| completion_case_fold | ||
| ).each(&method(:attr_accessor)).freeze |
Member
There was a problem hiding this comment.
Please separate #freeze to another request.
Member
|
Thank you, merged! |
Contributor
Author
|
Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring
class Relineand add tests.TODO
reline::historyrelinetoreline::corereline