Merged
Conversation
1. Uses current Ruby builds, also master 2. Changes download-test_readline.bat to a PowerShell script 3. PowerShell script also renames readline.so to readline.no
Current workflows restrict branch pushes to 'master', hinders contributors working in forks.
MSP-Greg
force-pushed
the
actions-windows
branch
from
dbbafbd to
66cf00d
Compare
Contributor
Author
|
I continued with another branch, replaced the Also, removed Appveyor. No need to wait if ruby/ruby is stacked up with CI there... See last two commits at: |
Member
|
Thank you. I'll consider the Ruby script version after Ruby 2.7 is released... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only affects CI.
Rework Windows CI -
1.1 change script that copies ruby/ruby files from a .bat script to a .ps1 script (PowerShell)
1.2 rename readline.so file
1.3 use an 'action' that installs current Rubies, versus the old Rubies on Actions.
1.4 move master/trunk testing to GitHub Actions ('9.9.x')
Allow CI to run in forks on branches other than 'master'
Split ci-test and test in Rakefile and workflows
Notes:
Windows Rubies 2.5 & 2.6 contain a readline.so file, but do not contain the dll they need to load.
Left AppVeyor CI as is.
To allow Ruby master to always work, it is versioned as '9.9.x' in the workflow matrix, and installed to the 'C:/Ruby99-x64' folder. When 2.7.0 release is available, I'll update the 'action'.