-
Notifications
You must be signed in to change notification settings - Fork 30
Description
Hello,
I've been trying to run this and noticed that the generated command:
setarch x86_64 -R nice -20 taskset -c 11 ruby --yjit -I ./harness benchmarks/optcarrot/benchmark.rb
actually causes the process to have a nice level of 19, the least priority, when trying locally on Linux.
It seems one needs nice -n -40 (can be tested with nice -n -40 sleep 1000) to actually use a negative nice level, and that also needs sudo (otherwise: nice: cannot set niceness: Permission denied and it has no effect).
BTW, I also noticed run_benchmarks.rb uses 4 spaces as indentation which is quite unusual for Ruby. I'd make a PR for it, but it's probably best if you change it to avoid any conflict.
Finally, my run failed with:
$ ./run_benchmarks.rb
...
Running benchmark "railsbench" (12/13)
setarch x86_64 -R nice -20 taskset -c 11 ruby --yjit -I ./harness benchmarks/railsbench/benchmark.rb
Could not find concurrent-ruby-1.1.8 in any of the sources
Run `bundle install` to install missing gems.
./run_benchmarks.rb:13:in `check_call': RuntimeError (RuntimeError)
from ./run_benchmarks.rb:220:in `block in run_benchmarks'
from ./run_benchmarks.rb:188:in `each'
from ./run_benchmarks.rb:188:in `each_with_index'
from ./run_benchmarks.rb:188:in `run_benchmarks'
from ./run_benchmarks.rb:282:in `<main>'
zsh: exit 1 ./run_benchmarks.rb
So I guess one should bundle install before in benchmarks/railsbench (either in README or by the harness).
bundle install currently fails though due to mimemagic 0.3.5 being yanked.