Fix a leak in Lobsters benchmark #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling the lobsters benchmark I'm seeing a fairly large time spent joining tags in TaggedLogger. That intruigued me, and by digging I noticed the requests UUIDs kept being appended but never removed. So for every single request we have one more tag, this is skewing the benchmark a bit, as we spend much more time than we should in logging.
|
After: 
|
k0kubun
reviewed
Sep 6, 2024
k0kubun
approved these changes
Sep 6, 2024
rwstauner
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling the lobsters benchmark I'm seeing a fairly large time spent joining tags in TaggedLogger.
That intruigued me, and by digging I noticed the requests UUIDs kept being appended but never removed.
So for every single request we have one more tag, this is skewing the benchmark a bit, as we spend much more time than we should in logging.