Re-enable Turbo Boost after running benchmarks #327
Conversation
| check_call("sudo -S sh -c 'echo 1 > /sys/devices/system/cpu/intel_pstate/no_turbo'") unless turbo || intel_no_turbo? | ||
| unless intel_no_turbo? || turbo | ||
| check_call("sudo -S sh -c 'echo 1 > /sys/devices/system/cpu/intel_pstate/no_turbo'") | ||
| at_exit { check_call("sudo -S sh -c 'echo 0 > /sys/devices/system/cpu/intel_pstate/no_turbo'", quiet: true) } |
There was a problem hiding this comment.
It seems better to not make it quiet here to let the user understand why e.g. the sudo password is asked again
There was a problem hiding this comment.
Sounds fair. Feel free to file a PR for it, but so far the 15-minute sudo timeout has been long enough for me to never encounter the situation when running benchmarks locally.
| at_exit { check_call("sudo -S sh -c 'echo 0 > /sys/devices/system/cpu/intel_pstate/no_turbo'", quiet: true) } | ||
| end | ||
| # Disabling Turbo Boost reduces the CPU frequency, so this should be run after that. | ||
| check_call("sudo -S sh -c 'echo 100 > /sys/devices/system/cpu/intel_pstate/min_perf_pct'") unless intel_perf_100pct? |
There was a problem hiding this comment.
This and sudo -S cpupower frequency-set -g performance below should probably also be undone then, otherwise they might e.g. consume a lot more power.
There was a problem hiding this comment.
I mean you've been fine with it so far, so it should be fine. I just kept the code simple by not introducing what I don't need. I'm personally not interested in lowering power consumption, but if you're, feel free to file a PR to change it.
3 participants
After yjit-bench disables Turbo Boost, it becomes slower to build Ruby and run tests. To avoid that, I want to re-enable Turbo Boost at exit.