Skip to content

Update run_benchmarks.rb to pass the JSON to render_graph #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Update run_benchmarks.rb to pass the JSON to render_graph #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
842444f
Update run_benchmarks.rb to pass the JSON to render_graph
eregon Oct 7, 2024
cbb0856
Check that --graph works in CI
eregon Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@ jobs:
MIN_BENCH_TIME: '0'
SKIP_BENCHMARKS: ${{ matrix.skip }}

- name: Test run_benchmarks.rb --graph
run: ./run_benchmarks.rb --graph fib
if: matrix.ruby == 'ruby'
env:
WARMUP_ITRS: '1'
MIN_BENCH_ITRS: '1'
MIN_BENCH_TIME: '0'

- name: Test run_once.sh
run: ./run_once.sh --yjit-stats benchmarks/railsbench/benchmark.rb
if: matrix.ruby == 'head'
4 changes: 2 additions & 2 deletions run_benchmarks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,14 +588,14 @@ def run_benchmarks(ruby:, ruby_description:, categories:, name_filters:, out_pat
# Print the table to the console, with numbers truncated
puts(output_str)

# Print CSV and PNG file names
# Print JSON and PNG file names
puts
puts "Output:"
puts out_json_path
if args.graph
require_relative 'misc/graph'
out_graph_path = output_path + ".png"
render_graph(out_tbl_path, out_graph_path)
render_graph(out_json_path, out_graph_path)
puts out_graph_path
end

Expand Down
Loading