Lobsters: Remove the transaction_retry gem #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a long abandoned gem that's incompatible with Ruby 3. I ran into the kwargs error in qertoip/transaction_retry#12 while running the burn-in script. Upstream lobsters removed this gem a year ago: lobsters/lobsters@eb1d5ef Looks like the gem is only used when DB operations fail, which pretty much never happens outside of burn-in runs where the host gets hammered, so hopefully no change to performance properties.
k0kubun
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long abandoned gem that's incompatible with Ruby 3. I ran
into the kwargs error in qertoip/transaction_retry#12
while running the burn-in script.
Upstream lobsters removed this gem a year ago: lobsters/lobsters@eb1d5ef
Looks like the gem is only used when DB operations fail, which pretty much
never happens outside of burn-in runs where the host gets hammered, so
hopefully no change to performance properties.