Extract CPU configuration logic into its own file #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekknolagi
approved these changes
Nov 20, 2025
|
|
||
| def have_yjit?(ruby) | ||
| ruby_version = check_output("#{ruby} -v --yjit", err: File::NULL).strip | ||
| ruby_version = `#{ruby} -v --yjit 2> #{File::NULL}`.strip |
Contributor
There was a problem hiding this comment.
why not continue using check_output here?
Collaborator
Author
There was a problem hiding this comment.
popen is overkill. It is the same answer as the Process case. Ruby has Kernel#` to do what we want, get the stdout of a subshell. There is no reason to reimplement it using popen
rwstauner
reviewed
Nov 20, 2025
| private | ||
|
|
||
| def disable_turbo_boost | ||
| # sudo requires the flag '-S' in order to take input from stdin |
Contributor
There was a problem hiding this comment.
I see that it's always been like this but I don't know why we are using -S.
| end | ||
|
|
||
| def maximize_frequency | ||
| # Disabling Turbo Boost reduces the CPU frequency, so this should be run after that. |
Contributor
There was a problem hiding this comment.
I feel like this comment should actually go in disable_frequency_scaling since that's where the order is important.
| end | ||
|
|
||
| unless frequency_maximized? | ||
| puts("You forgot to set the min perf percentage to 100:") |
Contributor
There was a problem hiding this comment.
Suggested change
| puts("You forgot to set the min perf percentage to 100:") | |
| puts("You forgot to set the min perf percentage to #{FREQUENCY_MAXIMIZED_VALUE}:") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add tests for it.