Silence warnings created by tests #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwstauner
commented
Nov 20, 2025
| out = capture_io do | ||
| assert_raises(SystemExit) { BenchmarkRunner.expand_pre_init('/nonexistent/file.rb') } | ||
| end | ||
| assert_includes out, "--with-pre-init called with non-existent file!\n" |
Contributor
Author
There was a problem hiding this comment.
I don't really care if we assert these or just ignore them but it's a pet peeve of mine to have the test output broken up by uncaught warnings (especially when they are properly induced by the test code).
k0kubun
approved these changes
Nov 21, 2025
rafaelfranca
approved these changes
Nov 21, 2025
Collaborator
rafaelfranca
left a comment
rafaelfranca
left a comment
There was a problem hiding this comment.
Those tests are later deleted in my branch, that is why I didn't fix them, but I'm ok with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.