Allow multiple benchmarks per folder in ruby-bench #445
+804
−255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
reviewed
Nov 21, 2025
Member
|
I wonder if we need any change for https://github.com/rubybench/rubybench and/or https://github.com/rubybench/rubybench.github.io to support this. cc: @eightbitraptor |
Collaborator
Author
It should not. The data generate is in the same format with the same keys. The way to execute is also the same. |
rafaelfranca
force-pushed
the
rmf-multiple-benches-per-folder
branch
from
00b07bd to
2d1d48b
Compare
eightbitraptor
approved these changes
Nov 27, 2025
Contributor
eightbitraptor
left a comment
eightbitraptor
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks 👍
rafaelfranca
force-pushed
the
rmf-multiple-benches-per-folder
branch
from
2d1d48b to
cd1365d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, benchmarks are organized, one per folder. For libraries like addressable, we have 9 folders with repeated Gemfile and Gemfile.lock.
This PR, adds the possibility of adding benchmarks for the same library into the same folder, each with a different name.