Remove spurious obj != klass check in shape_get_next

tekknolagi · tenderlove · tekknolagi · commit 612a66805f35 · 2025-12-03T16:59:05.000-05:00
This should never be true. I added an `rb_bug` in case it was and it
wasn't true in any of btest or test-all.

Co-authored-by: Aaron Patterson &lt;tenderlove@ruby-lang.org&gt;
diff --git a/shape.c b/shape.c
@@ -839,7 +839,7 @@ shape_get_next(rb_shape_t *shape, enum shape_type shape_type, VALUE obj, ID id,
     }
 
     // Check if we should update max_iv_count on the object's class
-    if (obj != klass && new_shape->next_field_index > RCLASS_MAX_IV_COUNT(klass)) {
+    if (new_shape->next_field_index > RCLASS_MAX_IV_COUNT(klass)) {
         RCLASS_SET_MAX_IV_COUNT(klass, new_shape->next_field_index);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -839,7 +839,7 @@ shape_get_next(rb_shape_t *shape, enum shape_type shape_type, VALUE obj, ID id,`
`839`	`839`	`}`
`840`	`840`
`841`	`841`	`// Check if we should update max_iv_count on the object's class`
`842`		`- if (obj != klass && new_shape->next_field_index > RCLASS_MAX_IV_COUNT(klass)) {`
	`842`	`+ if (new_shape->next_field_index > RCLASS_MAX_IV_COUNT(klass)) {`
`843`	`843`	`RCLASS_SET_MAX_IV_COUNT(klass, new_shape->next_field_index);`
`844`	`844`	`}`
`845`	`845`